-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTNN-653 Rebaseline for v7 development #261
base: develop
Are you sure you want to change the base?
Conversation
Changes look good.
See bplib-dtnn-653.zip attached. Build is in bplib-dtnn-653/build-bplib.
See the logs in the tar file:
|
d211b41
to
01d9a08
Compare
Great work!
|
@gskenned Replying to your comments:
|
06d6307
to
485b911
Compare
I built and ran with cosmos, running the test suite there and it worked without issue. Ran the unit tests and those were successful as well. I looked through the changes. I did not look at absolutely everything - after a point I started skimming through them noting that the general, repeating pattern was there. It looks good. |
Describe the contribution
Addresses DTNN-653. Rebaselines the repo with the necessary build structure and initial files needed for v7 development
Testing performed
Unit and build tests
Expected behavior changes
Library prototype is wiped and replaced with initial v7 files. All components have an empty init function and unit test framework.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Sara Garcia-Beech